[PATCH] D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create.

[Puyan Lotfi via Phabricator via cfe-commits]

plotfi created this revision.
plotfi added reviewers: jkorous, compnerd, gribozavr.
Herald added subscribers: cfe-commits, dexonsmith.
Herald added a project: clang.

Also I went ahead and replaced all the instances of "auto DW = DirectoryWatcher::create" with "llvm::Expected<std::unique_ptr<DirectoryWatcher>> DW = DirectoryWatcher::create(" to make it more clear that DirectoryWatcher::create is returning an llvm::Expected (along wit a comment to make it extra clear).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D65829

Files:
  clang/include/clang/DirectoryWatcher/DirectoryWatcher.h
  clang/lib/DirectoryWatcher/linux/DirectoryWatcher-linux.cpp
  clang/lib/DirectoryWatcher/mac/DirectoryWatcher-mac.cpp
  clang/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65829.213716.patch
Type: text/x-patch
Size: 9009 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190806/467e7cd7/attachment-0001.bin>