[PATCH] D65484: [analyzer][NFC] Refactoring BugReporter.cpp P5.: Compact mile long function invocations into objects

Kristóf Umann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Aug 4 15:51:14 PDT 2019


Szelethus marked an inline comment as done.
Szelethus added inline comments.


================
Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:111
+/// getters and some well placed asserts for extra security.
+class BugReportConstruct {
+  /// The consumer we're constructing the bug report for.
----------------
NoQ wrote:
> You mean `Construct` like a noun? Not sure what that means.
> 
> Maybe `PathDiagnosticContext`?
Yea, I originally wanted to have the class name `BaconStrip` so that it screams just a bit louder that I couldnt come up with anything good, but maybe `PathDiagnosticConstruction` or something like that would be better.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65484/new/

https://reviews.llvm.org/D65484





More information about the cfe-commits mailing list