[PATCH] D65484: [analyzer][NFC] Refactoring BugReporter.cpp P5.: Compact mile long function invocations into objects

[Artem Dergachev via Phabricator via cfe-commits]

NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.

*bows down to those who bestow documentation upon this code*



================
Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:111
+/// getters and some well placed asserts for extra security.
+class BugReportConstruct {
+  /// The consumer we're constructing the bug report for.
----------------
You mean `Construct` like a noun? Not sure what that means.

Maybe `PathDiagnosticContext`?


================
Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:127
+  /// that instead?
+  StackDiagVector CallStack;
+  InterestingExprs IE;
----------------
Dunno, "Diag" near "Vector" kinda reads to me more like "Diagonal".


================
Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:140
+  /// bug path.
+  const LocationContext *getCurrLocationContext() const {
+    assert(CurrentNode && "Already reached the root!");
----------------
> Curr

Purr? =^.^=


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65484/new/

https://reviews.llvm.org/D65484