[PATCH] D65577: [ASTImporter] Import default expression of param before creating the param.
Shafik Yaghmour via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Aug 1 09:47:40 PDT 2019
shafik added inline comments.
================
Comment at: clang/lib/AST/ASTImporter.cpp:3859
ToTypeSourceInfo, D->getStorageClass(),
/*DefaultArg*/ nullptr))
return ToParm;
----------------
This should be `DefaultArg` now?
================
Comment at: clang/test/Analysis/Inputs/ctu-other.cpp:135
+
+struct DefParmContext {
+ static const int I;
----------------
martong wrote:
> Perhaps we could write `Default` instead of `Def`.
+1 to this and the name suggestion below.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65577/new/
https://reviews.llvm.org/D65577
More information about the cfe-commits
mailing list