[PATCH] D65577: [ASTImporter] Import default expression of param before creating the param.

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 1 08:32:37 PDT 2019


martong accepted this revision.
martong added a comment.
This revision is now accepted and ready to land.

LGTM, though I have some comments.



================
Comment at: clang/test/Analysis/Inputs/ctu-other.cpp:135
+
+struct DefParmContext {
+  static const int I;
----------------
Perhaps we could write `Default` instead of `Def`.


================
Comment at: clang/test/Analysis/Inputs/ctu-other.cpp:144
+
+int testDefParmIncompleteImport(int I) {
+  return fDefParm(I);
----------------
`testImportOfIncompleteDefaultParm` ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65577/new/

https://reviews.llvm.org/D65577





More information about the cfe-commits mailing list