[PATCH] D61466: [Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug

[Joel E. Denny via Phabricator via cfe-commits]

jdenny added a comment.

In D61466#1602917 <https://reviews.llvm.org/D61466#1602917>, @jkorous wrote:

> Hi @jdenny, thanks for the warning!


Hi.  Thanks for the review.

> I think having the test disabled is fine - the main upside I see is that we won't check it fails over and over on our CI systems.

In an inline comment, you also mentioned the alternative of replacing `EXPECT_EQ` with `EXPECT_NE`.  Neither solution is the XFAIL I'm used to (from lit for example).

I chose disabling purely because I saw some other unit tests do this.  What do people normally recommend for llvm unit tests?

> Could you please mention the test/reproducer in those FIXMEs?

Will do.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61466/new/

https://reviews.llvm.org/D61466