[PATCH] D61466: [Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug

Fri Jul 26 11:09:18 PDT 2019

jkorous added a comment.

Hi @jdenny, thanks for the warning! I think having the test disabled is fine - the main upside I see is that we won't check it fails over and over on our CI systems.
Could you please mention the test/reproducer in those FIXMEs?
Otherwise LGTM.

================
Comment at: clang/unittests/Rewrite/RewriteBufferTest.cpp:17

+#define EXPECT_OUTPUT(Buf, Output) EXPECT_EQ(Output, writeOutput(Buf))
+
----------------
I think in case you really wanted to have an "XFAIL", you could have just used `EXPECT_NE` here.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61466/new/

https://reviews.llvm.org/D61466