[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

Mon Jul 8 16:23:01 PDT 2019

jdoerfert marked 2 inline comments as done.
jdoerfert added a comment.

In D64375#1574662 <https://reviews.llvm.org/D64375#1574662>, @ABataev wrote:

> The scheme itself looks good in general.

Good. Once we agreed on a scheme we can improve the actual process, excel sheet, generator script, etc. (see also below).

> Just as an improvement, it would be good to use coloring for the feature status.

I'll try to add coloring.

> Also, what's the difference between claimed, mostly done and done?

Disclaimer: I used a script to determine what the columns in the excel document mean. There is a good chance I got some wrong and it only reflects the information in the document.

I basically used the following logic in this order:

1. If all non-empty columns contain the word "done", mark it as "done".
2. If all non-empty columns contain "mostly complete", mark it as "mostly done".
3. If there are non-empty columns, mark it as "claimed", e.g., someone is working on it.
4. If there are only empty columns, mark it as "unclaimed", e.g., not being worked on right now.

I think when we go through the excel document now with this use case in mind and fill the empty columns appropriately, some errors will dissapear.

================
Comment at: clang/docs/OpenMPSupport.rst:153
++------------------------------+--------------------------------------------------------------+--------------+--------------------------------------------+
+| loop extension               | collapse non-rectangular nested loop                         | unclaimed    |                                            |
++------------------------------+--------------------------------------------------------------+--------------+--------------------------------------------+
----------------
ABataev wrote:
> I'm working on this feature, but don't know when it's going to be ready.
That will then be noted in the excel sheet (see general comment).

================
Comment at: clang/docs/OpenMPSupport.rst:219
++------------------------------+--------------------------------------------------------------+--------------+--------------------------------------------+
+| device extension             | Fortran pointer mapping                                      | unclaimed    |                                            |
++------------------------------+--------------------------------------------------------------+--------------+--------------------------------------------+
----------------
ABataev wrote:
> Do we really need Fortran stuff here?
No, I already filtered by hand, my mistake. Will automate it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64375/new/

https://reviews.llvm.org/D64375