[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 8 12:03:48 PDT 2019


rjmccall added a comment.

Please don't check IR names in test output.  That actually includes anonymous names like `%2`; these should always be tested with FileCheck variables.  I suggest using `%.*` as the pattern; if you're matching the LHS of an LLVM assignment, that shouldn't have problems with accidentally matching too much.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63846/new/

https://reviews.llvm.org/D63846





More information about the cfe-commits mailing list