[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

The change itself doesn't really bother me at all, however the test will fail if we build without preserving names.  In order to validate this you'll have to do fno-discard-value-names on a test.



================
Comment at: clang/test/CodeGenOpenCL/address-spaces-conversions.cl:16
   arg_gen = &var_priv; // implicit cast with obtaining adr, private -> generic
-  // CHECK: %{{[0-9]+}} = addrspacecast i32* %var_priv to i32 addrspace(4)*
+  // CHECK: %var_priv.ascast = addrspacecast i32* %var_priv to i32 addrspace(4)*
   // CHECK-NOFAKE-NOT: addrspacecast
----------------
You probably don't want to remove the wildcard here.  If this is built without names being saved, this change will fail.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63846/new/

https://reviews.llvm.org/D63846