[PATCH] D64133: [clangd] Add HadErrors field into shards
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jul 3 09:50:44 PDT 2019
kadircet marked an inline comment as done.
kadircet added inline comments.
================
Comment at: clang-tools-extra/clangd/Headers.h:65
struct IncludeGraphNode {
- // True if current file is a main file rather than a header.
- bool IsTU = false;
+ enum class SourceFlag : uint8_t {
+ None = 0,
----------------
sammccall wrote:
> nit: I'd tend to use a plain enum here to avoid the operator boilerplate, but up to you
I was more worried about incidental usages like:
```
IncludeGraphNode IGN;
if(IGN.IsTU) blabla;
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64133/new/
https://reviews.llvm.org/D64133
More information about the cfe-commits
mailing list