[PATCH] D64133: [clangd] Add HadErrors field into shards

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 3 09:14:11 PDT 2019


sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/Headers.h:65
 struct IncludeGraphNode {
-  // True if current file is a main file rather than a header.
-  bool IsTU = false;
+  enum class SourceFlag : uint8_t {
+    None = 0,
----------------
nit: I'd tend to use a plain enum here to avoid the operator boilerplate, but up to you


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64133/new/

https://reviews.llvm.org/D64133





More information about the cfe-commits mailing list