[PATCH] D63535: [clang][AST] ASTNameGenerator: A refactoring of CodegenNameGeneratorImpl (NFC).
Puyan Lotfi via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jun 19 10:21:36 PDT 2019
plotfi marked an inline comment as done.
plotfi added inline comments.
================
Comment at: clang/include/clang/AST/Mangle.h:249-250
+struct ASTNameGenerator {
+ std::unique_ptr<MangleContext> MC;
+ llvm::DataLayout DL;
+
----------------
aaron.ballman wrote:
> Do these still need to be public members? Back when this class was an implementation detail, that didn't matter as much, but I'd prefer a cleaner public interface before we expose this to other consumers.
Good catch! This was a struct when it was CodegenNameGeneratorImpl but these were hidden by the mere fact that they were inside the .cpp file and not in a header. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63535/new/
https://reviews.llvm.org/D63535
More information about the cfe-commits
mailing list