[PATCH] D63535: [clang][AST] ASTNameGenerator: A refactoring of CodegenNameGeneratorImpl (NFC).
Saleem Abdulrasool via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jun 19 10:19:23 PDT 2019
compnerd added inline comments.
================
Comment at: clang/include/clang/AST/Mangle.h:248
+
+struct ASTNameGenerator {
+ std::unique_ptr<MangleContext> MC;
----------------
Please make this a `class` and hide the members, exposing just the constructor and the 3 methods as @aaron.ballman pointed out that this is a `struct` not a `class`! I missed that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63535/new/
https://reviews.llvm.org/D63535
More information about the cfe-commits
mailing list