[PATCH] D63080: [analyzer] Track indices of arrays

[Balogh, Ádám via Phabricator via cfe-commits]

baloghadamsoftware requested changes to this revision.
baloghadamsoftware added inline comments.
This revision now requires changes to proceed.


================
Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1681
+    trackExpressionValue(
+        LVNode, Arr->getIdx(), report, EnableNullFPSuppression);
+
----------------
NoQ wrote:
> Mmm, dunno about null fp suppression. We're, like, talking about integers. Integers are more often zero than null. We generally do support some FP suppressions for integers as well (i.e., `core.DivideZero` uses them), but in this case it doesn't sound as if `0` is anyhow special.
I agree here. Forwarding `EnableNUllFPSuppression` does not really make sense for the array index even if it was `true` for the array element.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63080/new/

https://reviews.llvm.org/D63080