[PATCH] D63080: [analyzer] Track indices of arrays

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 10 19:06:26 PDT 2019


NoQ added a comment.

Whoa, this looks like a much needed improvement, i'm glad that you found it!



================
Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1681
+    trackExpressionValue(
+        LVNode, Arr->getIdx(), report, EnableNullFPSuppression);
+
----------------
Mmm, dunno about null fp suppression. We're, like, talking about integers. Integers are more often zero than null. We generally do support some FP suppressions for integers as well (i.e., `core.DivideZero` uses them), but in this case it doesn't sound as if `0` is anyhow special.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63080/new/

https://reviews.llvm.org/D63080





More information about the cfe-commits mailing list