[PATCH] D59407: [clangd] Add RelationSlab

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 27 00:55:19 PDT 2019


sammccall accepted this revision.
sammccall added a comment.

Awesome, thank you!



================
Comment at: clang-tools-extra/clangd/index/Relation.h:75
+  private:
+    std::vector<Relation> Relations;
+  };
----------------
kadircet wrote:
> maybe use a set so that we can be sure that there won't be any duplicates. sorry for missing that in the previous iteration.
(you're sorting the array at the end anyway, so sort + unique + erase seems neater)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59407/new/

https://reviews.llvm.org/D59407





More information about the cfe-commits mailing list