[PATCH] D59407: [clangd] Add RelationSlab

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

LGTM, except the duplication issue. Thanks!



================
Comment at: clang-tools-extra/clangd/index/Relation.h:75
+  private:
+    std::vector<Relation> Relations;
+  };
----------------
maybe use a set so that we can be sure that there won't be any duplicates. sorry for missing that in the previous iteration.


================
Comment at: clang-tools-extra/clangd/unittests/IndexTests.cpp:79
 
+TEST(RelationSlab, Lookup) {
+  SymbolID A{"A"};
----------------
could you also add a test case that's inserting duplicate relations?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59407/new/

https://reviews.llvm.org/D59407