[PATCH] D61424: [ASTImporter] Fix inequivalence of unresolved exception spec

Aleksei Sidorin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat May 4 03:11:19 PDT 2019


a_sidorin accepted this revision.
a_sidorin added a comment.
This revision is now accepted and ready to land.

Looks good!



================
Comment at: clang/lib/AST/ASTImporter.cpp:3107
+    // noexcept-unevaluated, while the newly imported function may have an
+    // evaluated noexcept.
   }
----------------
This looks to be true -  a call `adjustExceptionSpec()` on the imported decl and its redeclarations can be required. Thank you for noticing this!


================
Comment at: clang/lib/AST/ASTStructuralEquivalence.cpp:325
 
+/// Check the eqeuivalence of exception specifications.
+static bool IsEquivalentExceptionSpec(StructuralEquivalenceContext &Context,
----------------
equivalence


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61424/new/

https://reviews.llvm.org/D61424





More information about the cfe-commits mailing list