[PATCH] D46421: [analyzer][CrossTU] Extend CTU to VarDecls with initializer

Gábor Horváth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 11 02:11:27 PDT 2019


xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.

I have one question, once it is resolved I am fine with committing this.



================
Comment at: lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:352
+        return true;
+    } else if (VD->isStaticDataMember()) {
+      // Only import if const.
----------------
Do we actually need this branch? I would expect `cross_tu::containsConst(VD, *Ctx)` to return true for all the cases where we would return true here.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D46421/new/

https://reviews.llvm.org/D46421





More information about the cfe-commits mailing list