[clang-tools-extra] r357994 - ClangTidy: Avoid mixing stdout with stderror when dealing with a large number of files.

Andi-Bogdan Postelnicu via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 9 04:17:03 PDT 2019


Author: abpostelnicu
Date: Tue Apr  9 04:17:02 2019
New Revision: 357994

URL: http://llvm.org/viewvc/llvm-project?rev=357994&view=rev
Log:
ClangTidy: Avoid mixing stdout with stderror when dealing with a large number of files.

Summary:
At Mozilla we are using this tool in order to perform review-time static-analysis, since some patches contain a large number of files we've discovered this issue, where `stderr` gets mixed with `stdout` thus obfuscating our possibility to parse the output.
The patch that we are currently use can be found [here](https://searchfox.org/mozilla-central/source/build/build-clang/clang-tidy-8.patch).

This is just an upstream of the original patch.

Reviewers: JonasToth

Reviewed By: JonasToth

Subscribers: cfe-commits

Tags: #clang, #clang-tools-extra

Differential Revision: https://reviews.llvm.org/D60453

Modified:
    clang-tools-extra/trunk/clang-tidy/tool/run-clang-tidy.py

Modified: clang-tools-extra/trunk/clang-tidy/tool/run-clang-tidy.py
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/tool/run-clang-tidy.py?rev=357994&r1=357993&r2=357994&view=diff
==============================================================================
--- clang-tools-extra/trunk/clang-tidy/tool/run-clang-tidy.py (original)
+++ clang-tools-extra/trunk/clang-tidy/tool/run-clang-tidy.py Tue Apr  9 04:17:02 2019
@@ -172,6 +172,7 @@ def run_tidy(args, tmpdir, build_path, q
     with lock:
       sys.stdout.write(' '.join(invocation) + '\n' + output.decode('utf-8') + '\n')
       if len(err) > 0:
+        sys.stdout.flush()
         sys.stderr.write(err.decode('utf-8') + '\n')
     queue.task_done()
 




More information about the cfe-commits mailing list