[PATCH] D60409: [clangd] Add -header-insertion=never flag to disable include insertion in code completion

[Sam McCall via Phabricator via cfe-commits]

sammccall accepted this revision.
sammccall marked 2 inline comments as done.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clangd/CodeComplete.cpp:1176
   // This is available after Sema has run.
-  llvm::Optional<IncludeInserter> Inserter;  // Available during runWithSema.
+  llvm::Optional<IncludeInserter> Inserter;  // Optional during runWithSema.
   llvm::Optional<URIDistance> FileProximity; // Initialized once Sema runs.
----------------
ioeric wrote:
> Why optional? In the current implementation, it's always initialized.
Oops, this was left-over from a previous iteration.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60409/new/

https://reviews.llvm.org/D60409