[PATCH] D60409: [clangd] Add -header-insertion=never flag to disable include insertion in code completion
Eric Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Apr 8 08:18:39 PDT 2019
ioeric added a comment.
lg!
================
Comment at: clangd/CodeComplete.cpp:1176
// This is available after Sema has run.
- llvm::Optional<IncludeInserter> Inserter; // Available during runWithSema.
+ llvm::Optional<IncludeInserter> Inserter; // Optional during runWithSema.
llvm::Optional<URIDistance> FileProximity; // Initialized once Sema runs.
----------------
Why optional? In the current implementation, it's always initialized.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60409/new/
https://reviews.llvm.org/D60409
More information about the cfe-commits
mailing list