[PATCH] D60500: [clangd] Refactor speculateCompletionFilter and also extract scope.
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Apr 10 04:48:18 PDT 2019
sammccall marked 2 inline comments as done.
sammccall added inline comments.
================
Comment at: clangd/CodeComplete.cpp:1542
+ assert(Offset <= Content.size());
+ StringRef Suffix = Content.take_front(Offset);
+ CompletionPrefix Result;
----------------
ioeric wrote:
> `Suffix` is actually a prefix of Content? This seems a bit confusing...
Haha, just checking we're all paying attention...
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60500/new/
https://reviews.llvm.org/D60500
More information about the cfe-commits
mailing list