[PATCH] D60500: [clangd] Refactor speculateCompletionFilter and also extract scope.
Eric Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Apr 10 03:30:48 PDT 2019
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm
================
Comment at: clangd/CodeComplete.cpp:1542
+ assert(Offset <= Content.size());
+ StringRef Suffix = Content.take_front(Offset);
+ CompletionPrefix Result;
----------------
`Suffix` is actually a prefix of Content? This seems a bit confusing...
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60500/new/
https://reviews.llvm.org/D60500
More information about the cfe-commits
mailing list