[PATCH] D59859: [clang-tidy] FIXIT for implicit bool conversion now obeys upper case suffixes if enforced.
Alexander Kornienko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Apr 1 09:45:24 PDT 2019
alexfh added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/readability/ImplicitBoolConversionCheck.cpp:270
+ AllowPointerConditions(Options.get("AllowPointerConditions", false)),
+ UseUppercaseLiteralSuffix(Context->isCheckEnabled("readability-uppercase-literal-suffix")) {}
----------------
Relying on enabled checks for this sort of a behavior is undesired. This sort of an implicit dependency will lead to problems, if, for example, a user wants to apply fixes check-by-check. A separate option (local for this check or better a global one - like `StrictMode`) would be better.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59859/new/
https://reviews.llvm.org/D59859
More information about the cfe-commits
mailing list