[PATCH] D59859: [clang-tidy] FIXIT for implicit bool conversion now obeys upper case suffixes if enforced.
Alexander Kornienko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Apr 1 08:28:05 PDT 2019
alexfh added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/readability/ImplicitBoolConversionCheck.cpp:48
case CK_IntegralToBoolean:
- return Type->isUnsignedIntegerType() ? "0u" : "0";
+ if (UppercaseSuffix) {
+ return Type->isUnsignedIntegerType() ? "0U" : "0";
----------------
MyDeveloperDay wrote:
> LLVM normally doesn't put braces on small lines
Maybe use a conditional operator instead?
return Type->isUnsignedIntegerType() ? (UppercaseSuffix ? "0U" : "0u") : "0";
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59859/new/
https://reviews.llvm.org/D59859
More information about the cfe-commits
mailing list