[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

Mon Mar 25 06:01:51 PDT 2019

Szelethus added a comment.

I think the idea is awesome, thanks!

We really need to not use `UINT_MAX`, and I think `static` fields and member functions are a bit overused in this patch -- can't we just make `getConfiguration` and `parseConfiguration` static non-member functions, and make them take `GenericTaintChecker` as an argument?

================
Comment at: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:73-75
   static const unsigned InvalidArgIndex = UINT_MAX;
   /// Denotes the return vale.
   static const unsigned ReturnValueIndex = UINT_MAX - 1;
----------------
We should definitely change these, not only is the large integer number impossible to remember, but this value could differ on different platforms.

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59555/new/

https://reviews.llvm.org/D59555