[PATCH] D59528: [clang-tidy] Expand modular headers for PPCallbacks

[Alexander Kornienko via Phabricator via cfe-commits]

alexfh marked 3 inline comments as done.
alexfh added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.cpp:166
+    Preprocessor->Lex(CurrentToken);
+}
+
----------------
gribozavr wrote:
> Haha, so the test that I asked to add did catch a bug -- just not the one I expected :)
Nope, the test passes without this. I'm not even sure this override is changing any observable behavior of PPCallbacks. I hope to find this out by running other checks on real code with modules enabled.


================
Comment at: clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.h:44
+  /// \brief Returns the preprocessor that provides callbacks for contents of
+  /// modular headers.
+  ///
----------------
gribozavr wrote:
> "... callbacks for the whole translation unit, including the main file, textual headers, and modular headers."
> 
> Sorry, I wrote the comment before I fully understood what this preprocessor does.
Indeed. Thanks for the text.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59528/new/

https://reviews.llvm.org/D59528