[PATCH] D59528: [clang-tidy] Expand modular headers for PPCallbacks

[Dmitri Gribenko via Phabricator via cfe-commits]

gribozavr accepted this revision.
gribozavr marked an inline comment as done.
gribozavr added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.cpp:166
+    Preprocessor->Lex(CurrentToken);
+}
+
----------------
Haha, so the test that I asked to add did catch a bug -- just not the one I expected :)


================
Comment at: clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.h:44
+  /// \brief Returns the preprocessor that provides callbacks for contents of
+  /// modular headers.
+  ///
----------------
"... callbacks for the whole translation unit, including the main file, textual headers, and modular headers."

Sorry, I wrote the comment before I fully understood what this preprocessor does.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59528/new/

https://reviews.llvm.org/D59528