[PATCH] D58880: [WIP] [Looking for API feedback] [clangd] Type hierarchy subtypes

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 8 00:03:11 PST 2019


kadircet added a comment.

Hi Nathan,

I would also suggest splitting up current changes so that we can start reviewing them, which might result in other changes in your planned changes and help reduce duplicate work both on our and your side.
Also please have a look at D59083 <https://reviews.llvm.org/D59083>, and make sure it helps implement what you have in might and let me know if there's anything missing.

As for splitting changes I would suggest something like:

- RelationSlab
- Serialization/Deserialization of the RelationSlab
- Integrating RelationSlab with SymbolCollector
- Adding queries to index structures(memindex, dex, mergedindex etc.)
- Surfacing those queries through typehierarchy request


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58880/new/

https://reviews.llvm.org/D58880





More information about the cfe-commits mailing list