[PATCH] D58880: [WIP] [Looking for API feedback] [clangd] Type hierarchy subtypes

Nathan Ridge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 7 18:02:43 PST 2019


nridge planned changes to this revision.
nridge added a comment.

Thanks for the detailed analysis!

For completeness, I think another advantage of option 3 is that it allows us to make the key for relation lookups be a (SymbolID, RelationKind) pair rather than just a SymbolID.

It sounds like I should continue implementing the current approach. Marking the revision as "changes planned" accordingly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58880/new/

https://reviews.llvm.org/D58880





More information about the cfe-commits mailing list