[PATCH] D59028: [OpenMP] Enable on device linking with NVLINK to ignore dynamic libraries

[Gheorghe-Teodor Bercea via Phabricator via cfe-commits]

gtbercea marked an inline comment as done.
gtbercea added inline comments.


================
Comment at: lib/Driver/ToolChains/Cuda.cpp:707
       CmdArgs.push_back(StaticLibName);
+    } else if (OrigInputFileName.endswith(".so")) {
+      // Only static libraries are supported.
----------------
ABataev wrote:
> I would suggest to use `types::lookupTypeForExtension` function and compare the result with the `types::TY_Object`.
Isn't that too broad? I only want .so files.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59028/new/

https://reviews.llvm.org/D59028