[PATCH] D59028: [OpenMP] Enable on device linking with NVLINK to ignore dynamic libraries

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 6 09:44:25 PST 2019


ABataev added inline comments.


================
Comment at: lib/Driver/ToolChains/Cuda.cpp:707
       CmdArgs.push_back(StaticLibName);
+    } else if (OrigInputFileName.endswith(".so")) {
+      // Only static libraries are supported.
----------------
I would suggest to use `types::lookupTypeForExtension` function and compare the result with the `types::TY_Object`.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59028/new/

https://reviews.llvm.org/D59028





More information about the cfe-commits mailing list