[PATCH] D58275: [clangd] Support utf-8 offsets (rather than utf-16) as a protocol extension
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Feb 15 04:50:56 PST 2019
sammccall added a comment.
In D58275#1399195 <https://reviews.llvm.org/D58275#1399195>, @hokein wrote:
> The code looks good. For this protocol extension, we need supports from other LSP clients, I think we may want to propose this extension to the LSP specification, so that all LSP servers/clients respect it.
My reading of https://github.com/Microsoft/language-server-protocol/issues/376 is that they may only accept a proposal that comes with patches to Microsoft's implementations.
I'm not likely to work on that soon (it doesn't directly get us closer to interop goals) so my preferred path is implement and document the extension, get some support from other language clients/servers, and then push again for standardization.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58275/new/
https://reviews.llvm.org/D58275
More information about the cfe-commits
mailing list