[PATCH] D58275: [clangd] Support utf-8 offsets (rather than utf-16) as a protocol extension

[Haojian Wu via Phabricator via cfe-commits]

hokein added a comment.

The code looks good. For this protocol extension, we need supports from other LSP clients, I think we may want to propose this extension to the LSP specification, so that all LSP servers/clients respect it.



================
Comment at: clangd/Protocol.h:377
+
+  /// Supported encodings for LSP character offsets. (clangd extension).
+  llvm::Optional<std::vector<OffsetEncoding>> offsetEncoding;
----------------
nit: also mention this is in preferred order.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58275/new/

https://reviews.llvm.org/D58275