[PATCH] D58178: [clang-tidy] RawStringLiteralCheck: isRawStringLiteral doesn't check all erroneous cases

Wed Feb 13 09:33:16 PST 2019

MyDeveloperDay added a comment.

Rather than sending a review, probably the reproducible case as to why it crash is more important, it might be better to write up your bug at https://bugs.llvm.org/

I tried to repoduce this and I can't see how I could make a string literal without a double quote, if it still failed with the current code it might suggest the matcher matched something else.. understanding what that is is probably more important, than just masking the failure.

there was a crash D19331: [Clang-tidy] Fix for crash in modernize-raw-string-literal check <https://reviews.llvm.org/D19331> which was fixed back in April, are you able to tell us the version/revision of clang-tidy where this occurred

Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58178/new/

https://reviews.llvm.org/D58178