[PATCH] D58178: [clang-tidy] RawStringLiteralCheck: isRawStringLiteral doesn't check all erroneous cases

Goran Mitrovic via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 13 08:51:07 PST 2019


gmit added a comment.

? I'm sorry, but I disagree.

Assert draws attention in the debug build only.

In the release build asserts are not evaluated at all and the condition needs to be checked in the code that executes (if it makes sense and in this case it does as it causes reading out of string bounds).

I don't have a test as I don't have an input file that causes this behaviour.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58178/new/

https://reviews.llvm.org/D58178





More information about the cfe-commits mailing list