[PATCH] D57797: Variable auto-init: fix __block initialization

JF Bastien via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 7 15:55:20 PST 2019


jfb marked 2 inline comments as done.
jfb added inline comments.


================
Comment at: lib/CodeGen/CGDecl.cpp:1726
+    emitByrefStructureInit(emission);
+  }
+
----------------
Note that we still want this to be pulled out in this way because `emitByrefStructureInit` emits the call to the initializer (in `test_block_self_init` the call to `create`). Were we to leave this as it was before, one of the initializations below would be emitted, but it would be *after* the call.

Similarly, we also want the little dance I added to only initialize once.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57797/new/

https://reviews.llvm.org/D57797





More information about the cfe-commits mailing list