[PATCH] D57797: Variable auto-init: fix __block initialization

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 7 15:53:53 PST 2019


rjmccall added inline comments.


================
Comment at: lib/CodeGen/CGDecl.cpp:1605
-    emitByrefStructureInit(emission);
-
   // Initialize the variable here if it doesn't have a initializer and it is a
----------------
Are these changes still needed?


================
Comment at: lib/CodeGen/CGDecl.cpp:1644
+    if (emission.IsEscapingByRef)
+      Loc = emitBlockByrefAddress(Loc, &D, /*follow=*/false);
 
----------------
Thanks, this is what I was looking for.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57797/new/

https://reviews.llvm.org/D57797





More information about the cfe-commits mailing list