r352862 - Disable tidy checks with too many hits

[Ilya Biryukov via cfe-commits]

Author: ibiryukov
Date: Fri Feb  1 03:20:13 2019
New Revision: 352862

URL: http://llvm.org/viewvc/llvm-project?rev=352862&view=rev
Log:
Disable tidy checks with too many hits

Summary:
Some tidy checks have too many hits in the codebase, making it hard to spot
other results from clang-tidy, therefore rendering the tool less useful.

Two checks were disabled:
  - misc-non-private-member-variable-in-classes in the whole LLVM monorepo,
    it is very common to have those in LLVM and the style guide does not forbid
    them.
  - readability-identifier-naming in the clang subtree. There are thousands of
    violations in 'Sema.h' alone.

Before the change, 'Sema.h' had >1000 tidy warnings, after the change the number
dropped to 3 warnings (unterminated namespace comments).

Reviewers: alexfh, hokein

Reviewed By: hokein

Subscribers: llvm-commits, cfe-commits

Tags: #clang, #llvm

Differential Revision: https://reviews.llvm.org/D57573

Modified:
    cfe/trunk/.clang-tidy

Modified: cfe/trunk/.clang-tidy
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/.clang-tidy?rev=352862&r1=352861&r2=352862&view=diff
==============================================================================
--- cfe/trunk/.clang-tidy (original)
+++ cfe/trunk/.clang-tidy Fri Feb  1 03:20:13 2019
@@ -1,4 +1,9 @@
-Checks: '-*,clang-diagnostic-*,llvm-*,misc-*,-misc-unused-parameters,readability-identifier-naming'
+Checks: '-*,clang-diagnostic-*,llvm-*,misc-*,-misc-unused-parameters,-misc-non-private-member-variables-in-classes,-readability-identifier-naming'
+# Note that the readability-identifier-naming check is disabled, there are too
+# many violations in the codebase and they create too much noise in clang-tidy
+# results.
+# Naming settings are kept for documentation purposes and allowing to run the
+# check if the users would override this file, e.g. via a command-line arg.
 CheckOptions:
   - key:             readability-identifier-naming.ClassCase
     value:           CamelCase