[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

Nick Renieris via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 28 20:09:37 PST 2019


VelocityRa updated this revision to Diff 184010.
VelocityRa added a comment.

I extracted the logic of `AlignTokens` and `AlignTokenSequence` that aligning macros uses to the best of my ability.

This new logic now resides in `AlignTokensAll` and `AlignTokenSequenceAll` (so that it may be re-used).

As far as re-using pieces of the implementation of //those// two with the former methods, I couldn't spot any patterns I could extract, that wouldn't make the code needlessly complicated (in my opinion).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D28462/new/

https://reviews.llvm.org/D28462

Files:
  docs/ClangFormatStyleOptions.rst
  include/clang/Format/Format.h
  lib/Format/Format.cpp
  lib/Format/WhitespaceManager.cpp
  lib/Format/WhitespaceManager.h
  unittests/Format/FormatTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28462.184010.patch
Type: text/x-patch
Size: 12920 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190129/f0eb7fae/attachment-0001.bin>


More information about the cfe-commits mailing list