[PATCH] D57104: [AST] Pack GenericSelectionExpr

[Bruno Ricci via Phabricator via cfe-commits]

riccibruno added a comment.

In D57104#1369985 <https://reviews.llvm.org/D57104#1369985>, @steveire wrote:

> There's definitely a better possible ordering in two commits:
>
> 1. Introduce `::Create` and port to it
> 2. Use trailing objects, taking advantage of the fact that `::Create` exists.
>
>   That would make it clear in the future to other people because both commits would be cleaner, both commit messages would say what the commit does, and neither commit would have the noise of the other change.
>
>   Not splitting this commit makes it less reviewable to people who are not around today.


I strongly disagree. The only reason for the `Create` method to exist is because we are using trailing objects.
It is not "oh nice `Create` exists, lets use it!". Furthermore, this is a standard pattern across the code-base and
this patch is already tiny.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57104/new/

https://reviews.llvm.org/D57104