[PATCH] D57104: [AST] Pack GenericSelectionExpr

[Stephen Kelly via Phabricator via cfe-commits]

steveire added a comment.

In D57104#1369985 <https://reviews.llvm.org/D57104#1369985>, @steveire wrote:

> There's definitely a better possible ordering in two commits:
>
> 1. Introduce `::Create` and port to it
> 2. Use trailing objects, taking advantage of the fact that `::Create` exists.
>
>   That would make it clear in the future to other people because both commits would be cleaner, both commit messages would say what the commit does, and neither commit would have the noise of the other change.
>
>   Not splitting this commit makes it less reviewable to people who are not around today.


I highly recommend this 9 minute video if this is new to you or you haven't seen it before: https://youtu.be/qpdYRPL3SVE?t=103


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57104/new/

https://reviews.llvm.org/D57104