[PATCH] D57114: Remove Expr sugar decorating the CXXUuidofExpr node.

Wed Jan 23 14:33:35 PST 2019

void marked 2 inline comments as done.
void added inline comments.

================
Comment at: lib/Sema/SemaTemplate.cpp:6311
         if (isa<CXXUuidofExpr>(E)) {
-          Converted = TemplateArgument(ArgResult.get());
+          Converted = TemplateArgument(ArgResult.get()->IgnoreImpCasts());
           break;
----------------
aaron.ballman wrote:
> `IgnoreParenImpCasts()` or are the paren expressions of value?
I want to make this a minimal change. Richard was okay with just the implicit casts. I'm not relaly qualified in this part of the code to say that we should also include parentheses in this. I'll leave that up to you and Richard.

  https://bugs.llvm.org/show_bug.cgi?id=40395

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57114/new/

https://reviews.llvm.org/D57114