[PATCH] D57114: Remove Expr sugar decorating the CXXUuidofExpr node.

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: lib/Sema/SemaTemplate.cpp:6311
         if (isa<CXXUuidofExpr>(E)) {
-          Converted = TemplateArgument(ArgResult.get());
+          Converted = TemplateArgument(ArgResult.get()->IgnoreImpCasts());
           break;
----------------
`IgnoreParenImpCasts()` or are the paren expressions of value?


================
Comment at: test/CodeGenCXX/pr40395.cpp:1
+// RUN: %clang_cc1 -std=c++17 -fms-extensions -emit-llvm %s -o - -triple=x86_64-pc-win32
+
----------------
Why is this test in CodeGenCXX instead of SemaCXX?

The RUN line doesn't seem to be testing anything? Should there be a `-verify` and `// expected-no-diagnostics` involved?

It might also be a good idea to add some comments that explain the test case.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57114/new/

https://reviews.llvm.org/D57114