[PATCH] D56860: [clangd] NFC: Use buildCompilerInvocation in CodeComplete

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 21 08:24:48 PST 2019


ilya-biryukov added a reviewer: sammccall.
ilya-biryukov added a comment.

Adding Sam as a reviewer, IIRC we used to have `buildCompilerInvocation` here and he was the one who inlined it.
I would personally LGTM this change (with the two comments fixed), but Sam might have a different opinion on whether this should be outlined again.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56860/new/

https://reviews.llvm.org/D56860





More information about the cfe-commits mailing list