[PATCH] D56860: [clangd] NFC: Use buildCompilerInvocation in CodeComplete

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 21 08:03:55 PST 2019


ilya-biryukov added inline comments.


================
Comment at: clangd/CodeComplete.cpp:1030
   auto &FrontendOpts = CI->getFrontendOpts();
   FrontendOpts.DisableFree = false;
   FrontendOpts.SkipFunctionBodies = true;
----------------
remove this line, `buildCompilerInvocation` handles this for us


================
Comment at: clangd/CodeComplete.cpp:1032
   FrontendOpts.SkipFunctionBodies = true;
   CI->getLangOpts()->CommentOpts.ParseAllComments = true;
   // Disable typo correction in Sema.
----------------
remove this line, buildCompilerInvocation handles this for us




Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56860/new/

https://reviews.llvm.org/D56860





More information about the cfe-commits mailing list