[PATCH] D47445: [ASTImporter] Corrected diagnostic client handling in tests.

[Balázs Kéri via Phabricator via cfe-commits]

balazske added a comment.

The new `ASTUnit::beginSourceFile` is only there to simplify the code. It is possible to get `Ctx`, `PP` and `getDiagnostic()` from outside of `ASTUnit` and call the same thing, but requires more code to write. Probably a more smart place to call `BeginSourceFile` can be found if we look deep into `ASTUnit` and `buildAST` functions that generate the AST from code that has associated source file but this would be a change that affects more code.


Repository:
  rC Clang

https://reviews.llvm.org/D47445