[PATCH] D47445: [ASTImporter] Corrected diagnostic client handling in tests.

Argyrios Kyrtzidis via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 31 12:08:44 PDT 2018


akyrtzi added a comment.

Thanks for the explanation. Please do add documentation comments for the new method so people using ASTUnit in their own code have an idea when and why they would need to call this. Something like "if you intend to emit additional diagnostics after the ASTUnit is created [...]". 
Also consider making the naming more clear to match the intended purpose, like `enableEmittingAdditionalDiagnostics()` or something similar.
Otherwise LGTM.


Repository:
  rC Clang

https://reviews.llvm.org/D47445





More information about the cfe-commits mailing list